comments: Update signature and settings. #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the plugin setting with plugin setting validation
amass01
changed the title
lukebp
requested changes
Aug 12, 2021
lukebp
reviewed
Aug 12, 2021
marcopeereboom
suggested changes
Aug 16, 2021
|
@marcopeereboom updated |
marcopeereboom
approved these changes
Aug 16, 2021
lukebp
requested changes
Aug 17, 2021
lukebp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds
ExtraData&ExtraDataHintfields to theSignaturefield in both
New&Editcomments plugin commands.Also, this updates the
Signaturevalidation and adds a newcomments plugin setting
allowExtraDatawith a new validation to ensureno extra data is provided while the setting is switched off.
Closes #1483.